Commit 8a2b62e
stream: ensure pipeline always destroys streams
There was an edge case where an incorrect assumption was made
in regardos whether eos/finished means that the stream is
actually destroyed or not.
Backport-PR-URL: #31975
PR-URL: #31940
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 313ecaa commit 8a2b62eCopy full SHA for 8a2b62e
File tree
Expand file treeCollapse file tree
2 files changed
+19
-13
lines changedOpen diff view settings
Filter options
- lib/internal/streams
- test/parallel
Expand file treeCollapse file tree
2 files changed
+19
-13
lines changedOpen diff view settings
Collapse file
lib/internal/streams/pipeline.js
Copy file name to clipboardExpand all lines: lib/internal/streams/pipeline.js+5-12Lines changed: 5 additions & 12 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
38 | 38 | |
39 | 39 | |
40 | 40 | |
41 | | - |
42 | | - |
43 | | - |
44 | | - |
45 | | - |
| 41 | + |
46 | 42 | |
47 | 43 | |
48 | 44 | |
49 | | - |
50 | | - |
51 | | - |
| 45 | + |
| 46 | + |
| 47 | + |
| 48 | + |
52 | 49 | |
53 | 50 | |
54 | | - |
55 | 51 | |
56 | | - |
57 | 52 | |
58 | 53 | |
59 | | - |
60 | 54 | |
61 | | - |
62 | 55 | |
63 | 56 | |
64 | 57 | |
|
Collapse file
test/parallel/test-stream-pipeline.js
Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipeline.js+14-1Lines changed: 14 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
763 | 763 | |
764 | 764 | |
765 | 765 | |
766 | | - |
| 766 | + |
| 767 | + |
| 768 | + |
| 769 | + |
767 | 770 | |
768 | 771 | |
769 | 772 | |
| ||
909 | 912 | |
910 | 913 | |
911 | 914 | |
| 915 | + |
| 916 | + |
| 917 | + |
| 918 | + |
| 919 | + |
| 920 | + |
| 921 | + |
| 922 | + |
| 923 | + |
| 924 | + |
0 commit comments