Commit 8a26ba1
test: fix flaky test-https-timeout
Remove `setTimeout()` in test and instead rely on `common.mustCall()` on
a `timeout` event handler.
The test was flaky on CI. The flakiness was replicable by running the
test under load. This version, in contrast, is robust under load.
Took the opportunity to do some `var` -> `const` while refactoring.
PR-URL: #10404
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent eeb2d78 commit 8a26ba1Copy full SHA for 8a26ba1
File tree
Expand file treeCollapse file tree
1 file changed
+11
-23
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+11
-23
lines changedOpen diff view settings
Collapse file
test/parallel/test-https-timeout.js
Copy file name to clipboard+11-23Lines changed: 11 additions & 23 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | | - |
| 2 | + |
3 | 3 | |
4 | 4 | |
5 | 5 | |
6 | 6 | |
7 | 7 | |
8 | | - |
| 8 | + |
9 | 9 | |
10 | | - |
| 10 | + |
11 | 11 | |
12 | | - |
| 12 | + |
13 | 13 | |
14 | 14 | |
15 | 15 | |
16 | 16 | |
17 | 17 | |
18 | | - |
| 18 | + |
19 | 19 | |
20 | | - |
21 | | - |
| 20 | + |
| 21 | + |
22 | 22 | |
23 | 23 | |
24 | 24 | |
| ||
28 | 28 | |
29 | 29 | |
30 | 30 | |
31 | | - |
| 31 | + |
32 | 32 | |
33 | 33 | |
34 | 34 | |
35 | | - |
36 | | - |
37 | | - |
38 | | - |
39 | | - |
40 | | - |
41 | | - |
42 | | - |
43 | | - |
44 | | - |
45 | | - |
46 | | - |
47 | | - |
| 35 | + |
48 | 36 | |
49 | 37 | |
50 | 38 | |
51 | 39 | |
52 | | - |
53 | | - |
| 40 | + |
| 41 | + |
0 commit comments