Commit 89961ba
committed
src: fix process.abort() interaction with V8
Since V8 5.9 V8 installs a default signal handler for some signals
when creating a default platform instance that prints a stack trace.
However, Node already does the same thing, so it would seem like the
two different stack traces would be printed; also, the V8 handler
would lead to a `SIGSEGV` under some circumstances, rather than
letting the abort continue normally.
Resolve this by disabling V8’s signal handler by default.
PR-URL: #13985
Fixes: #13865
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent da1913c commit 89961baCopy full SHA for 89961ba
File tree
Expand file treeCollapse file tree
3 files changed
+28
-22
lines changedOpen diff view settings
Filter options
- src
- test
- abort
- async-hooks
Expand file treeCollapse file tree
3 files changed
+28
-22
lines changedOpen diff view settings
Collapse file
+4-1Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
247 | 247 | |
248 | 248 | |
249 | 249 | |
250 | | - |
| 250 | + |
| 251 | + |
| 252 | + |
| 253 | + |
251 | 254 | |
252 | 255 | |
253 | 256 | |
|
Collapse file
test/abort/test-process-abort-exitcode.js
Copy file name to clipboard+24Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
Collapse file
test/async-hooks/async-hooks.status
Copy file name to clipboardExpand all lines: test/async-hooks/async-hooks.status-21Lines changed: 0 additions & 21 deletions
This file was deleted.
0 commit comments