Commit 88d760c
benchmark: fix benchmark/run.js handling of --set
run.js does not work with --set as it tries to include it as
options to `fork()` rather than as part of argv for `fork()`. This
doesn't throw an error because of a quirk in `fork()` that silently
accepts arrays for options objects. This will be changing in Node.js
18.x.
PR-URL: #41334
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 1150963 commit 88d760cCopy full SHA for 88d760c
File tree
Expand file treeCollapse file tree
1 file changed
+1
-2
lines changedOpen diff view settings
Filter options
- benchmark
Expand file treeCollapse file tree
1 file changed
+1
-2
lines changedOpen diff view settings
Collapse file
+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
42 | 42 | |
43 | 43 | |
44 | 44 | |
45 | | - |
46 | | - |
| 45 | + |
47 | 46 | |
48 | 47 | |
49 | 48 | |
|
0 commit comments