Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 887417e

Browse filesBrowse files
bryancr89BethGriggs
authored andcommitted
test: remove message from strictEqual assertions
When an AssertionError happens, the value of headers['set-cookie'] is not reported. That information is useful for debugging. Hence removed the value passed as the message in deepStrictEqual assertions of test/parallel/test-http2-cookies.js Backport-PR-URL: #22850 PR-URL: #20174 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent fa5a380 commit 887417e
Copy full SHA for 887417e

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-http2-cookies.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http2-cookies.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ server.on('listening', common.mustCall(() => {
4848

4949
req.on('response', common.mustCall((headers) => {
5050
assert(Array.isArray(headers['set-cookie']));
51-
assert.deepStrictEqual(headers['set-cookie'], setCookie,
52-
'set-cookie header does not match');
51+
assert.deepStrictEqual(headers['set-cookie'], setCookie);
5352
}));
5453

5554
req.on('end', common.mustCall(() => {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.