Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8814d03

Browse filesBrowse files
cjihrigBridgeAR
authored andcommitted
doc,lib,test: rename node-report to report
This commit completes the renaming of node-report to report in order to better differentiate core's reporting from the node-report npm module. PR-URL: #26371 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 11bd5e0 commit 8814d03
Copy full SHA for 8814d03

File tree

Expand file treeCollapse file tree

4 files changed

+7
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+7
-7
lines changed
Open diff view settings
Collapse file

‎doc/api/report.md‎

Copy file name to clipboardExpand all lines: doc/api/report.md
+3-3Lines changed: 3 additions & 3 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ is provided below for reference.
3232
"/home/nodeuser/project/node/out/Release/node",
3333
"--experimental-report",
3434
"--diagnostic-report-uncaught-exception",
35-
"/home/nodeuser/project/node/test/node-report/test-exception.js",
35+
"/home/nodeuser/project/node/test/report/test-exception.js",
3636
"child"
3737
],
3838
"nodejsVersion": "v12.0.0-pre",
@@ -66,8 +66,8 @@ is provided below for reference.
6666
"javascriptStack": {
6767
"message": "Error: *** test-exception.js: throwing uncaught Error",
6868
"stack": [
69-
"at myException (/home/nodeuser/project/node/test/node-report/test-exception.js:9:11)",
70-
"at Object.<anonymous> (/home/nodeuser/project/node/test/node-report/test-exception.js:12:3)",
69+
"at myException (/home/nodeuser/project/node/test/report/test-exception.js:9:11)",
70+
"at Object.<anonymous> (/home/nodeuser/project/node/test/report/test-exception.js:12:3)",
7171
"at Module._compile (internal/modules/cjs/loader.js:718:30)",
7272
"at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)",
7373
"at Module.load (internal/modules/cjs/loader.js:617:32)",
Collapse file

‎lib/internal/bootstrap/pre_execution.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/pre_execution.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function prepareMainThreadExecution() {
1111
// Only main thread receives signals.
1212
setupSignalHandlers();
1313

14-
// Process initial configurations of node-report, if any.
14+
// Process initial diagnostic reporting configuration, if present.
1515
initializeReport();
1616
initializeReportSignalHandlers(); // Main-thread-only.
1717

Collapse file

‎lib/internal/process/execution.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/execution.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ function createFatalException() {
102102
// call that threw and was never cleared. So clear it now.
103103
clearDefaultTriggerAsyncId();
104104

105-
// If node-report is enabled, call into its handler to see
105+
// If diagnostic reporting is enabled, call into its handler to see
106106
// whether it is interested in handling the situation.
107107
// Ignore if the error is scoped inside a domain.
108108
// use == in the checks as we want to allow for null and undefined
@@ -119,7 +119,7 @@ function createFatalException() {
119119
report.onUnCaughtException(er ? er.stack : undefined);
120120
}
121121
}
122-
} catch {} // NOOP, node_report unavailable.
122+
} catch {} // Ignore the exception. Diagnostic reporting is unavailable.
123123
}
124124

125125
if (exceptionHandlerState.captureFn !== null) {
Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ function skipIfInspectorDisabled() {
635635

636636
function skipIfReportDisabled() {
637637
if (!process.config.variables.node_report) {
638-
skip('Node Report is disabled');
638+
skip('Diagnostic reporting is disabled');
639639
}
640640
}
641641

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.