Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 87e9014

Browse filesBrowse files
Trottcodebytere
authored andcommitted
test: remove common.PORT from test-net-pause
Switch test-net-pause from common.PORT to a port assigned by the operating system. PR-URL: #31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 3fbd5ab commit 87e9014
Copy full SHA for 87e9014

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎test/pummel/test-net-pause.js‎

Copy file name to clipboardExpand all lines: test/pummel/test-net-pause.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
const common = require('../common');
23+
require('../common');
2424
const assert = require('assert');
2525
const net = require('net');
2626

@@ -43,7 +43,7 @@ const server = net.createServer((connection) => {
4343
});
4444

4545
server.on('listening', () => {
46-
const client = net.createConnection(common.PORT);
46+
const client = net.createConnection(server.address().port);
4747
client.setEncoding('ascii');
4848
client.on('data', (d) => {
4949
console.log(d);
@@ -83,7 +83,7 @@ server.on('listening', () => {
8383
client.end();
8484
});
8585
});
86-
server.listen(common.PORT);
86+
server.listen(0);
8787

8888
process.on('exit', () => {
8989
assert.strictEqual(recv.length, N);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.