Commit 87ca9a6
test: fix flaky child-process-exec-kill-throws
This is a fix for test-child-process-exec-kill-throws which is currently
flaky on Windows.
A bug in the test was causing the child process to fail for reasons
other than those intended by the test. Instead of failing for exceeding
the `maxBuffer` setting, the test was failing because it was trying to
load `internal/child_process` without being passed the
`expose-internals` flag. Move that module to where only the parent
process (which gets the flag) loads it.
Additionally, improve an assertion message to help debug problems like
this.
PR-URL: #12111
Fixes: #12053
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent fdf76d5 commit 87ca9a6Copy full SHA for 87ca9a6
File tree
Expand file treeCollapse file tree
2 files changed
+5
-7
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
2 files changed
+5
-7
lines changedOpen diff view settings
Collapse file
test/parallel/parallel.status
Copy file name to clipboardExpand all lines: test/parallel/parallel.status-3Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
7 | 7 | |
8 | 8 | |
9 | 9 | |
10 | | - |
11 | | - |
12 | | - |
13 | 10 | |
14 | 11 | |
15 | 12 | |
|
Collapse file
test/parallel/test-child-process-exec-kill-throws.js
Copy file name to clipboardExpand all lines: test/parallel/test-child-process-exec-kill-throws.js+5-4Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3 | 3 | |
4 | 4 | |
5 | 5 | |
6 | | - |
7 | 6 | |
8 | 7 | |
9 | | - |
10 | | - |
| 8 | + |
| 9 | + |
11 | 10 | |
| 11 | + |
| 12 | + |
12 | 13 | |
13 | 14 | |
14 | 15 | |
| ||
21 | 22 | |
22 | 23 | |
23 | 24 | |
24 | | - |
| 25 | + |
25 | 26 | |
26 | 27 | |
27 | 28 | |
|
0 commit comments