Commit 878b2e7
benchmark: remove unreachable code from crypto/hash-stream-creation
`hash.digest('buffer')` has returned a Buffer and not a string since at
least Node.js 0.10.6. The benchmark, as it is written, will not work on
any version of Node.js prior to 16.x (due to `Object.hasOwn()`) and
certainly won't run on versions earlier than 0.10.6 due to const/let and
probably other things. Remove impossible-to-reach code intended to
accommodate Node.js earlier than 0.10.6.
PR-URL: #41535
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent be63dc5 commit 878b2e7Copy full SHA for 878b2e7
File tree
Expand file treeCollapse file tree
1 file changed
+1
-5
lines changedOpen diff view settings
Filter options
- benchmark/crypto
Expand file treeCollapse file tree
1 file changed
+1
-5
lines changedOpen diff view settings
Collapse file
benchmark/crypto/hash-stream-creation.js
Copy file name to clipboardExpand all lines: benchmark/crypto/hash-stream-creation.js+1-5Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
52 | 52 | |
53 | 53 | |
54 | 54 | |
55 | | - |
56 | | - |
57 | | - |
58 | | - |
59 | | - |
| 55 | + |
60 | 56 | |
61 | 57 | |
62 | 58 | |
|
0 commit comments