Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 86bbd5e

Browse filesBrowse files
kvakilruyadorno
kvakil
authored and
ruyadorno
committed
test: tune down parallelism for some flaky tests
These tests seem to timeout quite often. I don't know why, but one possible reason is that they are starting a lot of threads. It seems that tests in `test/parallel` are assumed to only start one thread each, so having 11 threads running at a time feels like a lot. It also seems that these tests fail in a correlated fashion: take a look at [this reliability report][]. The failures all occur on the same build machines on the same PRs. This suggests to me some sort of CPU contention. [this reliability report]: nodejs/reliability#334 On my Linux machine decreasing the parallelism & iterations here reduce the `user` time from ~11.5 seconds to ~2 seconds, depending on the test. I have seen these tests take 30-60 seconds on CI (Alpine in particular). I went back to the diffs that introduced that introduced these changes and verified that they failed at least 90% of the time with the reduced iteration count, which feels sufficient. Refs: #43499 Refs: #43084 PR-URL: #44090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 763b956 commit 86bbd5e
Copy full SHA for 86bbd5e

File tree

Expand file treeCollapse file tree

3 files changed

+6
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-6
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-worker-fshandles-error-on-termination.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-fshandles-error-on-termination.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ const fs = require('fs/promises');
66
const { scheduler } = require('timers/promises');
77
const { parentPort, Worker } = require('worker_threads');
88

9-
const MAX_ITERATIONS = 20;
10-
const MAX_THREADS = 10;
9+
const MAX_ITERATIONS = 5;
10+
const MAX_THREADS = 6;
1111

1212
// Do not use isMainThread so that this test itself can be run inside a Worker.
1313
if (!process.env.HAS_STARTED_WORKER) {
Collapse file

‎test/parallel/test-worker-fshandles-open-close-on-termination.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-fshandles-open-close-on-termination.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ const fs = require('fs/promises');
66
const { scheduler } = require('timers/promises');
77
const { parentPort, Worker } = require('worker_threads');
88

9-
const MAX_ITERATIONS = 20;
10-
const MAX_THREADS = 10;
9+
const MAX_ITERATIONS = 5;
10+
const MAX_THREADS = 6;
1111

1212
// Do not use isMainThread so that this test itself can be run inside a Worker.
1313
if (!process.env.HAS_STARTED_WORKER) {
Collapse file

‎test/parallel/test-worker-http2-stream-terminate.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-http2-stream-terminate.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ const { Worker, parentPort } = require('worker_threads');
1111
// stream activity is ongoing, in particular the C++ function
1212
// ReportWritesToJSStreamListener::OnStreamAfterReqFinished.
1313

14-
const MAX_ITERATIONS = 20;
15-
const MAX_THREADS = 10;
14+
const MAX_ITERATIONS = 5;
15+
const MAX_THREADS = 6;
1616

1717
// Do not use isMainThread so that this test itself can be run inside a Worker.
1818
if (!process.env.HAS_STARTED_WORKER) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.