Commit 856baf4
test: make spawnSync() test robust
The test had checked that a timer fired within a period after
spawnSync() returns. The result was a test that sometimes was
flaky.
Because there's no guarantee of how long a timer will take
before running, remove the check. There is a check that the
timer runs after spawnSync() so that is sufficient.
PR-URL: #2535
Fixes: #2470
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent f2f0fe4 commit 856baf4Copy full SHA for 856baf4
File tree
Expand file treeCollapse file tree
1 file changed
+0
-4
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+0
-4
lines changedOpen diff view settings
Collapse file
test/parallel/test-child-process-spawnsync.js
Copy file name to clipboardExpand all lines: test/parallel/test-child-process-spawnsync.js-4Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
7 | 7 | |
8 | 8 | |
9 | 9 | |
10 | | - |
11 | | - |
12 | 10 | |
13 | | - |
14 | 11 | |
15 | | - |
16 | 12 | |
17 | 13 | |
18 | 14 | |
|
0 commit comments