Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 84efadf

Browse filesBrowse files
RamirezAlextargos
authored andcommitted
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values, the use of strictEquals and the format actual, expected PR-URL: #28878 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0b6a84a commit 84efadf
Copy full SHA for 84efadf

File tree

Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-util.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-util.js
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,11 @@ assert.strictEqual(util.isError([]), false);
7373
assert.strictEqual(util.isError(Object.create(Error.prototype)), true);
7474

7575
// isObject
76-
assert.ok(util.isObject({}) === true);
76+
assert.strictEqual(util.isObject({}), true);
77+
assert.strictEqual(util.isObject([]), true);
78+
assert.strictEqual(util.isObject(new Number(3)), true);
79+
assert.strictEqual(util.isObject(Number(4)), false);
80+
assert.strictEqual(util.isObject(1), false);
7781

7882
// isPrimitive
7983
assert.strictEqual(util.isPrimitive({}), false);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.