Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 83d2b77

Browse filesBrowse files
pgeisscjihrig
authored andcommitted
buffer: remove unnecessary TODO comments
Refs: #4642 PR-URL: #4719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent da550aa commit 83d2b77
Copy full SHA for 83d2b77

File tree

Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Collapse file

‎lib/buffer.js‎

Copy file name to clipboardExpand all lines: lib/buffer.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -523,8 +523,6 @@ Buffer.prototype.fill = function fill(val, start, end) {
523523
};
524524

525525

526-
// TODO(trevnorris): fix these checks to follow new standard
527-
// write(string, offset = 0, length = buffer.length, encoding = 'utf8')
528526
var writeWarned = false;
529527
const writeMsg = 'Buffer.write(string, encoding, offset, length) is ' +
530528
'deprecated. Use write(string[, offset[, length]]' +
@@ -617,8 +615,6 @@ Buffer.prototype.toJSON = function() {
617615
};
618616

619617

620-
// TODO(trevnorris): currently works like Array.prototype.slice(), which
621-
// doesn't follow the new standard for throwing on out of range indexes.
622618
Buffer.prototype.slice = function slice(start, end) {
623619
const buffer = this.subarray(start, end);
624620
Object.setPrototypeOf(buffer, Buffer.prototype);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.