Commit 838179b
doc: correct tracingChannel.traceCallback()
tracingChannel.traceCallback() requires a callback otherwise it throws
and invalid argument error. As a result arguments are not optional.
Correct the documentation to reflect that arguments are not optional.
Besides that correct description regarding signaling of errors.
Remove an unneeded null check in wrappedCallback() which can't happen
because it's validated that callback is of type function.
PR-URL: #51068
Fixes: #50996
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>1 parent 539bee4 commit 838179bCopy full SHA for 838179b
File tree
Expand file treeCollapse file tree
2 files changed
+10
-12
lines changedOpen diff view settings
Filter options
- doc/api
- lib
Expand file treeCollapse file tree
2 files changed
+10
-12
lines changedOpen diff view settings
Collapse file
doc/api/diagnostics_channel.md
Copy file name to clipboardExpand all lines: doc/api/diagnostics_channel.md+9-9Lines changed: 9 additions & 9 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
853 | 853 | |
854 | 854 | |
855 | 855 | |
856 | | - |
| 856 | + |
857 | 857 | |
858 | 858 | |
859 | 859 | |
| ||
864 | 864 | |
865 | 865 | |
866 | 866 | |
867 | | - |
| 867 | + |
| 868 | + |
| 869 | + |
868 | 870 | |
869 | | - |
| 871 | + |
870 | 872 | |
871 | 873 | |
872 | | - |
| 874 | + |
| 875 | + |
873 | 876 | |
874 | 877 | |
875 | 878 | |
876 | | - |
877 | | - |
| 879 | + |
| 880 | + |
878 | 881 | |
879 | 882 | |
880 | 883 | |
881 | | - |
882 | | - |
883 | | - |
884 | 884 | |
885 | 885 | |
886 | 886 | |
|
Collapse file
+1-3Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
371 | 371 | |
372 | 372 | |
373 | 373 | |
374 | | - |
375 | | - |
376 | | - |
| 374 | + |
377 | 375 | |
378 | 376 | |
379 | 377 | |
|
0 commit comments