Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8372ea2

Browse filesBrowse files
thefourtheyervagg
authored andcommitted
doc,test: enable recursive file watching in Windows
Recursive file watching is supported by libuv since 1.7.0. Refer https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This patch notes that in the docs and enables testing this feature. It also adds proper TAP plugin parsable message for other platforms. PR-URL: #2649 Fixes: #375 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
1 parent aa1140e commit 8372ea2
Copy full SHA for 8372ea2

File tree

Expand file treeCollapse file tree

2 files changed

+6
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-4
lines changed
Open diff view settings
Collapse file

‎doc/api/fs.markdown‎

Copy file name to clipboardExpand all lines: doc/api/fs.markdown
+3-3Lines changed: 3 additions & 3 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -625,9 +625,9 @@ the event.
625625
The `fs.watch` API is not 100% consistent across platforms, and is
626626
unavailable in some situations.
627627

628-
The recursive option is currently supported on OS X. Only FSEvents supports this
629-
type of file watching so it is unlikely any additional platforms will be added
630-
soon.
628+
The recursive option is currently supported on OS X and Windows. Only FSEvents
629+
supports this type of file watching so it is unlikely any additional platforms
630+
will be added soon.
631631

632632
#### Availability
633633

Collapse file

‎test/sequential/test-fs-watch-recursive.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-fs-watch-recursive.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var assert = require('assert');
44
var path = require('path');
55
var fs = require('fs');
66

7-
if (process.platform === 'darwin') {
7+
if (process.platform === 'darwin' || common.isWindows) {
88
var watchSeenOne = 0;
99

1010
var testDir = common.tmpDir;
@@ -46,4 +46,6 @@ if (process.platform === 'darwin') {
4646
setTimeout(function() {
4747
fs.writeFileSync(filepathOne, 'world');
4848
}, 10);
49+
} else {
50+
console.log('1..0 # Skipped: recursive option is darwin/windows specific');
4951
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.