Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 833d3d5

Browse filesBrowse files
rexagodBridgeAR
authored andcommitted
doc: clarify commit message format in pull-requests.md
Resolved ambiguous meanings for the term `body of commit message` in `pull-requests.md` file, Fixes: #28068 PR-URL: #28125 Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 720a2a6 commit 833d3d5
Copy full SHA for 833d3d5

File tree

Expand file treeCollapse file tree

1 file changed

+3
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-8
lines changed
Open diff view settings
Collapse file

‎doc/guides/contributing/pull-requests.md‎

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md
+3-8Lines changed: 3 additions & 8 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,9 @@ Sample complete commit message:
176176
```txt
177177
subsystem: explain the commit in one line
178178
179-
Body of commit message is a few lines of text, explaining things
180-
in more detail, possibly giving some background about the issue
181-
being fixed, etc.
182-
183-
The body of the commit message can be several paragraphs, and
184-
please do proper word-wrap and keep columns shorter than about
185-
72 characters or so. That way, `git log` will show things
186-
nicely even when it is indented.
179+
The body of the commit message should be one or more paragraphs, explaining
180+
things in more detail. Please word-wrap to keep columns to 72 characters or
181+
less.
187182
188183
Fixes: https://github.com/nodejs/node/issues/1337
189184
Refs: http://eslint.org/docs/rules/space-in-parens.html

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.