Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 80f4a37

Browse filesBrowse files
Josh MaysMylesBorins
authored andcommitted
test: refactor test-pipe-file-to-http
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent a983400 commit 80f4a37
Copy full SHA for 80f4a37

File tree

Expand file treeCollapse file tree

1 file changed

+19
-22
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+19
-22
lines changed
Open diff view settings
Collapse file
+19-22Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
4-
var fs = require('fs');
5-
var http = require('http');
6-
var path = require('path');
7-
var cp = require('child_process');
2+
const common = require('../common');
3+
const assert = require('assert');
4+
const fs = require('fs');
5+
const http = require('http');
6+
const path = require('path');
7+
const cp = require('child_process');
88

99
common.refreshTmpDir();
1010

11-
var filename = path.join(common.tmpDir || '/tmp', 'big');
12-
var clientReqComplete = false;
13-
var count = 0;
11+
const filename = path.join(common.tmpDir || '/tmp', 'big');
12+
let count = 0;
1413

15-
var server = http.createServer(function(req, res) {
16-
var timeoutId;
17-
assert.equal('POST', req.method);
14+
const server = http.createServer(function(req, res) {
15+
let timeoutId;
16+
assert.strictEqual('POST', req.method);
1817
req.pause();
1918

2019
setTimeout(function() {
@@ -36,27 +35,26 @@ var server = http.createServer(function(req, res) {
3635
server.listen(0);
3736

3837
server.on('listening', function() {
39-
var cmd = common.ddCommand(filename, 10240);
38+
const cmd = common.ddCommand(filename, 10240);
4039

41-
cp.exec(cmd, function(err, stdout, stderr) {
40+
cp.exec(cmd, function(err) {
4241
if (err) throw err;
4342
makeRequest();
4443
});
4544
});
4645

4746
function makeRequest() {
48-
var req = http.request({
47+
const req = http.request({
4948
port: server.address().port,
5049
path: '/',
5150
method: 'POST'
5251
});
5352

54-
var s = fs.ReadStream(filename);
53+
const s = fs.ReadStream(filename);
5554
s.pipe(req);
56-
s.on('close', function(err) {
57-
if (err) throw err;
58-
clientReqComplete = true;
59-
});
55+
s.on('close', common.mustCall((err) => {
56+
assert.ifError(err);
57+
}));
6058

6159
req.on('response', function(res) {
6260
res.resume();
@@ -67,6 +65,5 @@ function makeRequest() {
6765
}
6866

6967
process.on('exit', function() {
70-
assert.equal(1024 * 10240, count);
71-
assert.ok(clientReqComplete);
68+
assert.strictEqual(1024 * 10240, count);
7269
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.