Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 809371a

Browse filesBrowse files
fossamagnaBethGriggs
authored andcommitted
module: require.resolve.paths returns null with node schema
require.resolve.paths should returns null with builtin module. when builtin module without `node:` schema, `paths` returns null. But, it don't return null when builtin module with `node:` schema. Fixes: #45001 PR-URL: #45147 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent efe1be4 commit 809371a
Copy full SHA for 809371a

File tree

Expand file treeCollapse file tree

2 files changed

+11
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+11
-2
lines changed
Open diff view settings
Collapse file

‎lib/internal/modules/cjs/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js
+7-2Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,13 @@ if (isWindows) {
737737
}
738738

739739
Module._resolveLookupPaths = function(request, parent) {
740-
if (BuiltinModule.canBeRequiredByUsers(request) &&
741-
BuiltinModule.canBeRequiredWithoutScheme(request)) {
740+
if ((
741+
StringPrototypeStartsWith(request, 'node:') &&
742+
BuiltinModule.canBeRequiredByUsers(StringPrototypeSlice(request, 5))
743+
) || (
744+
BuiltinModule.canBeRequiredByUsers(request) &&
745+
BuiltinModule.canBeRequiredWithoutScheme(request)
746+
)) {
742747
debug('looking for %j in []', request);
743748
return null;
744749
}
Collapse file

‎test/parallel/test-require-resolve.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-require-resolve.js
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js'));
6363
assert.strictEqual(require.resolve.paths(mod), null);
6464
});
6565

66+
builtinModules.forEach((mod) => {
67+
assert.strictEqual(require.resolve.paths(`node:${mod}`), null);
68+
});
69+
6670
// node_modules.
6771
const resolvedPaths = require.resolve.paths('eslint');
6872
assert.strictEqual(Array.isArray(resolvedPaths), true);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.