Commit 7fb72a5
committed
deps,src: align ssize_t ABI between Node & nghttp2
Previously, we performed casts that are considered undefined behavior.
Instead, just define `ssize_t` for nghttp2 the same way we define it
for the rest of Node.
Also, remove a TODO comment that would probably also be *technically*
correct but shouldn’t matter as long as nobody is complaining.
PR-URL: #18565
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 7dd3c8a commit 7fb72a5Copy full SHA for 7fb72a5
File tree
Expand file treeCollapse file tree
3 files changed
+14
-14
lines changedOpen diff view settings
Filter options
- deps/nghttp2/lib/includes
- src
Expand file treeCollapse file tree
3 files changed
+14
-14
lines changedOpen diff view settings
Collapse file
deps/nghttp2/lib/includes/config.h
Copy file name to clipboardExpand all lines: deps/nghttp2/lib/includes/config.h+12-2Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | 3 | |
4 | | - |
5 | | - |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
6 | 16 | |
7 | 17 | |
8 | 18 | |
|
Collapse file
-1Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
184 | 184 | |
185 | 185 | |
186 | 186 | |
187 | | - |
188 | 187 | |
189 | 188 | |
190 | 189 | |
|
Collapse file
+2-11Lines changed: 2 additions & 11 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
764 | 764 | |
765 | 765 | |
766 | 766 | |
767 | | - |
768 | | - |
769 | | - |
770 | | - |
771 | | - |
772 | | - |
773 | | - |
| 767 | + |
774 | 768 | |
775 | 769 | |
776 | 770 | |
| ||
1709 | 1703 | |
1710 | 1704 | |
1711 | 1705 | |
1712 | | - |
1713 | | - |
1714 | | - |
1715 | | - |
| 1706 | + |
1716 | 1707 | |
1717 | 1708 | |
1718 | 1709 | |
|
0 commit comments