Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7fb4794

Browse filesBrowse files
Trottevanlucas
Trott
authored and
evanlucas
committed
test: increase RAM requirement for intensive tests
test-fs-read-buffer-tostring-fail and test-fs-readfile-tostring-fail have been timing out on Raspberry Pi 3 devices on the continuous integration server. These devices have 1 Gb of RAM and the tests are memory intensive. Previous checks for memory intensive tests used a 512 Mb cut-off, but that was probably instituted when we only had Pi 1 devices. Consequently, this change increases the threshold for memory-intensive tests to 1 Gb and adds that threshold to test-fs-readfile-tostring-fail. PR-URL: #7772 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 4839ef3 commit 7fb4794
Copy full SHA for 7fb4794

File tree

Expand file treeCollapse file tree

2 files changed

+8
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-1
lines changed
Open diff view settings
Collapse file

‎test/common.js‎

Copy file name to clipboardExpand all lines: test/common.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ exports.isLinuxPPCBE = (process.platform === 'linux') &&
2727
exports.isSunOS = process.platform === 'sunos';
2828
exports.isFreeBSD = process.platform === 'freebsd';
2929

30-
exports.enoughTestMem = os.totalmem() > 0x20000000; /* 512MB */
30+
exports.enoughTestMem = os.totalmem() > 0x40000000; /* 1 Gb */
3131
exports.rootDir = exports.isWindows ? 'c:\\' : '/';
3232

3333
function rimrafSync(p) {
Collapse file

‎test/parallel/test-fs-readfile-tostring-fail.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-readfile-tostring-fail.js
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
'use strict';
22

33
const common = require('../common');
4+
5+
if (!common.enoughTestMem) {
6+
const skipMessage = 'intensive toString tests due to memory confinements';
7+
common.skip(skipMessage);
8+
return;
9+
}
10+
411
const assert = require('assert');
512
const fs = require('fs');
613
const path = require('path');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.