Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7fa5f54

Browse filesBrowse files
danbevtargos
authored andcommitted
src: remove trace_sync_io_ from env
This commit removes trace_sync_io_ and instead uses the options value directly. PR-URL: #22726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent 649288b commit 7fa5f54
Copy full SHA for 7fa5f54

File tree

Expand file treeCollapse file tree

4 files changed

+2
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+2
-6
lines changed
Open diff view settings
Collapse file

‎src/env-inl.h‎

Copy file name to clipboardExpand all lines: src/env-inl.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ inline void Environment::set_printed_error(bool value) {
416416
}
417417

418418
inline void Environment::set_trace_sync_io(bool value) {
419-
trace_sync_io_ = value;
419+
options_->trace_sync_io = value;
420420
}
421421

422422
inline bool Environment::abort_on_uncaught_exception() const {
Collapse file

‎src/env.cc‎

Copy file name to clipboardExpand all lines: src/env.cc
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ Environment::Environment(IsolateData* isolate_data,
113113
tick_info_(context->GetIsolate()),
114114
timer_base_(uv_now(isolate_data->event_loop())),
115115
printed_error_(false),
116-
trace_sync_io_(false),
117116
abort_on_uncaught_exception_(false),
118117
emit_env_nonstring_warning_(true),
119118
makecallback_cntr_(0),
@@ -309,7 +308,7 @@ void Environment::StopProfilerIdleNotifier() {
309308
}
310309

311310
void Environment::PrintSyncTrace() const {
312-
if (!trace_sync_io_)
311+
if (!options_->trace_sync_io)
313312
return;
314313

315314
HandleScope handle_scope(isolate());
Collapse file

‎src/env.h‎

Copy file name to clipboardExpand all lines: src/env.h
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -888,7 +888,6 @@ class Environment {
888888
TickInfo tick_info_;
889889
const uint64_t timer_base_;
890890
bool printed_error_;
891-
bool trace_sync_io_;
892891
bool abort_on_uncaught_exception_;
893892
bool emit_env_nonstring_warning_;
894893
size_t makecallback_cntr_;
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3054,8 +3054,6 @@ inline int Start(Isolate* isolate, IsolateData* isolate_data,
30543054
env.async_hooks()->pop_async_id(1);
30553055
}
30563056

3057-
env.set_trace_sync_io(env.options()->trace_sync_io);
3058-
30593057
{
30603058
SealHandleScope seal(isolate);
30613059
bool more;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.