nodejs
diff --git a/Collapse file
‎lib/console.js‎
Copy file name to clipboardExpand all lines: lib/console.js
+4-1Lines changed: 4 additions & 1 deletion b/Collapse file
‎lib/console.js‎
Copy file name to clipboardExpand all lines: lib/console.js
+4-1Lines changed: 4 additions & 1 deletion
diff --git a/Collapse file
‎test/parallel/test-console-instance.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-console-instance.js
+6Lines changed: 6 additions & 0 deletions b/Collapse file
‎test/parallel/test-console-instance.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-console-instance.js
+6Lines changed: 6 additions & 0 deletions
@@ -132,7 +132,10 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
   var keys = Object.keys(Console.prototype);
   for (var v = 0; v < keys.length; v++) {
     var k = keys[v];
-    this[k] = Console.prototype[k].bind(this);
+    // We have to bind the methods grabbed from the instance instead of from
+    // the prototype so that users extending the Console can override them
+    // from the prototype chain of the subclass.
+    this[k] = this[k].bind(this);
   }
 }
 
 
@@ -105,10 +105,16 @@ out.write = err.write = (d) => {};
 {
   class MyConsole extends Console {
     hello() {}
+    // See if the methods on Console.prototype are overridable.
+    log() { return 'overridden'; }
   }
   const myConsole = new MyConsole(process.stdout);
   assert.strictEqual(typeof myConsole.hello, 'function');
   assert.ok(myConsole instanceof Console);
+  assert.strictEqual(myConsole.log(), 'overridden');
+
+  const log = myConsole.log;
+  assert.strictEqual(log(), 'overridden');
 }
 
 // Instance that does not ignore the stream errors.
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,10 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {`
`132`	`132`	`var keys = Object.keys(Console.prototype);`
`133`	`133`	`for (var v = 0; v < keys.length; v++) {`
`134`	`134`	`var k = keys[v];`
`135`		`- this[k] = Console.prototype[k].bind(this);`
	`135`	`+ // We have to bind the methods grabbed from the instance instead of from`
	`136`	`+ // the prototype so that users extending the Console can override them`
	`137`	`+ // from the prototype chain of the subclass.`
	`138`	`+ this[k] = this[k].bind(this);`
`136`	`139`	`}`
`137`	`140`	`}`
`138`	`141`
Original file line number	Diff line number	Diff line change
`@@ -105,10 +105,16 @@ out.write = err.write = (d) => {};`
`105`	`105`	`{`
`106`	`106`	`class MyConsole extends Console {`
`107`	`107`	`hello() {}`
	`108`	`+ // See if the methods on Console.prototype are overridable.`
	`109`	`+ log() { return 'overridden'; }`
`108`	`110`	`}`
`109`	`111`	`const myConsole = new MyConsole(process.stdout);`
`110`	`112`	`assert.strictEqual(typeof myConsole.hello, 'function');`
`111`	`113`	`assert.ok(myConsole instanceof Console);`
	`114`	`+ assert.strictEqual(myConsole.log(), 'overridden');`
	`115`	`+`
	`116`	`+ const log = myConsole.log;`
	`117`	`+ assert.strictEqual(log(), 'overridden');`
`112`	`118`	`}`
`113`	`119`
`114`	`120`	`// Instance that does not ignore the stream errors.`