Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7ec097f

Browse filesBrowse files
RafaelGSSjuanarbol
authored andcommitted
doc: mention cherry-pick edge-case on release
PR-URL: #44408 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4a40251 commit 7ec097f
Copy full SHA for 7ec097f

File tree

Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Open diff view settings
Collapse file

‎doc/contributing/releases.md‎

Copy file name to clipboardExpand all lines: doc/contributing/releases.md
+6Lines changed: 6 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -698,10 +698,16 @@ placeholders (that happens when a change previously landed on another release
698698
branch), keep both version numbers. Convert the YAML field to an array if it is
699699
not already one.
700700

701+
[It's possible that the `cherry-pick` step will end up adding and/or
702+
changing unwanted lines](https://github.com/nodejs/Release/issues/771),
703+
please validate the changes in `doc/` folder files before confirming/continuing
704+
the cherry-pick step.
705+
701706
Then finish cherry-picking and push the commit upstream:
702707

703708
```console
704709
$ git add src/node_version.h doc
710+
$ git diff --staged src doc # read output to validate that changes shows up as expected
705711
$ git cherry-pick --continue
706712
$ make lint
707713
$ git push upstream main

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.