Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7eb8040

Browse filesBrowse files
Trottaddaleax
authored andcommitted
test: add debugging for callbacks in test-https-foafssl.js
The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: #24397 PR-URL: #34603 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4dbc787 commit 7eb8040
Copy full SHA for 7eb8040

File tree

Expand file treeCollapse file tree

1 file changed

+6
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-https-foafssl.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-https-foafssl.js
+6-3Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const server = https.createServer(options, common.mustCall(function(req, res) {
5656
assert.strictEqual(cert.exponent, exponent);
5757
assert.strictEqual(cert.modulus, modulus);
5858
res.writeHead(200, { 'content-type': 'text/plain' });
59-
res.end(body);
59+
res.end(body, () => { console.log('stream finished'); });
6060
console.log('sent response');
6161
}));
6262

@@ -74,8 +74,11 @@ server.listen(0, function() {
7474
const message = data.toString();
7575
const contents = message.split(CRLF + CRLF).pop();
7676
assert.strictEqual(body, contents);
77-
server.close();
78-
console.log('server closed');
77+
server.close((e) => {
78+
assert.ifError(e);
79+
console.log('server closed');
80+
});
81+
console.log('server.close() called');
7982
});
8083

8184
client.stdin.write('GET /\n\n');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.