Commit 7e10697
test: make cctest fixture use node::NewIsolate
This commit updates the gtest fixture to use node::NewIsolate instead of
creating a new V8 Isolate using v8::Isolate::New.
The motivation for this is that without calling node::NewIsolate the
various callbacks set on the isolate, for example AddMessageListener,
SetFatalErrorHandler etc, would not get set. I don't think this is the
expected behaviour and I ran into this when writing a new cctest.
PR-URL: #21419
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 4fc05ac commit 7e10697Copy full SHA for 7e10697
File tree
Expand file treeCollapse file tree
2 files changed
+7
-7
lines changedOpen diff view settings
Filter options
- test/cctest
Expand file treeCollapse file tree
2 files changed
+7
-7
lines changedOpen diff view settings
Collapse file
test/cctest/node_test_fixture.cc
Copy file name to clipboard+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
| 3 | + |
3 | 4 | |
4 | 5 | |
5 | | - |
6 | 6 | |
7 | | - |
Collapse file
test/cctest/node_test_fixture.h
Copy file name to clipboardExpand all lines: test/cctest/node_test_fixture.h+6-5Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
53 | 53 | |
54 | 54 | |
55 | 55 | |
| 56 | + |
| 57 | + |
56 | 58 | |
57 | 59 | |
58 | 60 | |
59 | | - |
| 61 | + |
60 | 62 | |
61 | 63 | |
62 | | - |
63 | 64 | |
64 | 65 | |
65 | 66 | |
| ||
68 | 69 | |
69 | 70 | |
70 | 71 | |
71 | | - |
72 | | - |
73 | 72 | |
74 | 73 | |
75 | 74 | |
| ||
85 | 84 | |
86 | 85 | |
87 | 86 | |
88 | | - |
| 87 | + |
| 88 | + |
| 89 | + |
89 | 90 | |
90 | 91 | |
91 | 92 | |
|
0 commit comments