Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7dd3c8a

Browse filesBrowse files
JiaHerr Teeaddaleax
authored andcommitted
test: add url type check in Module options
The code coverage in `root/internal/vm/Module.js` lacked test coverage for the url options paramter. The test adds a check to ensure error is thrown. PR-URL: #18664 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent be9777c commit 7dd3c8a
Copy full SHA for 7dd3c8a

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-vm-module-errors.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-vm-module-errors.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ async function checkArgType() {
4444
});
4545

4646
for (const invalidOptions of [
47-
0, 1, null, true, 'str', () => {}, Symbol.iterator
47+
0, 1, null, true, 'str', () => {}, { url: 0 }, Symbol.iterator
4848
]) {
4949
common.expectsError(() => {
5050
new Module('', invalidOptions);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.