Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7dd2f41

Browse filesBrowse files
authored
module: runtime deprecate exports double slash maps
PR-URL: #44495 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent a157e55 commit 7dd2f41
Copy full SHA for 7dd2f41

File tree

Expand file treeCollapse file tree

2 files changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎doc/api/deprecations.md‎

Copy file name to clipboardExpand all lines: doc/api/deprecations.md
+4-1Lines changed: 4 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -3201,13 +3201,16 @@ The [`--trace-atomics-wait`][] flag is deprecated.
32013201

32023202
<!-- YAML
32033203
changes:
3204+
- version: REPLACEME
3205+
pr-url: https://github.com/nodejs/node/pull/44495
3206+
description: Runtime deprecation.
32043207
- version: REPLACEME
32053208
pr-url: https://github.com/nodejs/node/pull/44477
32063209
description: Documentation-only deprecation
32073210
with `--pending-deprecation` support.
32083211
-->
32093212

3210-
Type: Documentation-only (supports [`--pending-deprecation`][])
3213+
Type: Runtime
32113214

32123215
Package imports and exports targets mapping into paths including a double slash
32133216
(of _"/"_ or _"\\"_) are deprecated and will fail with a resolution validation
Collapse file

‎lib/internal/modules/esm/resolve.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/resolve.js
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ const {
3333
Stats,
3434
} = require('fs');
3535
const { getOptionValue } = require('internal/options');
36-
const pendingDeprecation = getOptionValue('--pending-deprecation');
3736
// Do not eagerly grab .manifest, it may be in TDZ
3837
const policy = getOptionValue('--experimental-policy') ?
3938
require('internal/process/policy') :
@@ -102,7 +101,6 @@ function emitTrailingSlashPatternDeprecation(match, pjsonUrl, base) {
102101
const doubleSlashRegEx = /[/\\][/\\]/;
103102

104103
function emitInvalidSegmentDeprecation(target, request, match, pjsonUrl, base) {
105-
if (!pendingDeprecation) { return; }
106104
const pjsonPath = fileURLToPath(pjsonUrl);
107105
const double = RegExpPrototypeExec(doubleSlashRegEx, target) !== null;
108106
process.emitWarning(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.