Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7dbb0d0

Browse filesBrowse files
RReverserMyles Borins
authored andcommitted
buffer: fix dataview-set benchmark
Improves numbers up to 4x by avoiding repetitive dynamic method lookup. PR-URL: #6922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
1 parent 20d3378 commit 7dbb0d0
Copy full SHA for 7dbb0d0

File tree

Expand file treeCollapse file tree

1 file changed

+5
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-3
lines changed
Open diff view settings
Collapse file

‎benchmark/buffers/dataview-set.js‎

Copy file name to clipboardExpand all lines: benchmark/buffers/dataview-set.js
+5-3Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,20 @@ function main(conf) {
4040
}
4141

4242
function benchInt(dv, fn, len, le) {
43-
var m = mod[fn];
43+
const m = mod[fn];
44+
const method = dv[fn];
4445
bench.start();
4546
for (var i = 0; i < len; i++) {
46-
dv[fn](0, i % m, le);
47+
method.call(dv, 0, i % m, le);
4748
}
4849
bench.end(len / 1e6);
4950
}
5051

5152
function benchFloat(dv, fn, len, le) {
53+
const method = dv[fn];
5254
bench.start();
5355
for (var i = 0; i < len; i++) {
54-
dv[fn](0, i * 0.1, le);
56+
method.call(dv, 0, i * 0.1, le);
5557
}
5658
bench.end(len / 1e6);
5759
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.