Commit 7d9eb17
http2: destroy when settingsFn throws an error
http2.connect should call destroy when init fails.
PR-URL: #28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent f4abf17 commit 7d9eb17Copy full SHA for 7d9eb17
File tree
Expand file treeCollapse file tree
2 files changed
+21
-1
lines changedOpen diff view settings
Filter options
- lib/internal/http2
- test/parallel
Expand file treeCollapse file tree
2 files changed
+21
-1
lines changedOpen diff view settings
Collapse file
+7-1Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
976 | 976 | |
977 | 977 | |
978 | 978 | |
979 | | - |
| 979 | + |
| 980 | + |
| 981 | + |
| 982 | + |
| 983 | + |
| 984 | + |
| 985 | + |
980 | 986 | |
981 | 987 | |
982 | 988 | |
|
Collapse file
test/parallel/test-http2-connect.js
Copy file name to clipboardExpand all lines: test/parallel/test-http2-connect.js+14Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
69 | 69 | |
70 | 70 | |
71 | 71 | |
| 72 | + |
| 73 | + |
| 74 | + |
| 75 | + |
| 76 | + |
| 77 | + |
| 78 | + |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
| 83 | + |
| 84 | + |
| 85 | + |
72 | 86 | |
73 | 87 | |
74 | 88 | |
|
0 commit comments