Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7d6acef

Browse filesBrowse files
bnoordhuisMyles Borins
authored andcommitted
test: listen on and connect to 127.0.0.1
Avoid transient DNS issues in test sequential/test-net-GH-5504 by using the IP address instead of the 'localhost' host name. Fixes: #6611 PR-URL: #7524 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
1 parent 0a85987 commit 7d6acef
Copy full SHA for 7d6acef

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-net-GH-5504.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-net-GH-5504.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ function server() {
3030
console.error('_socketEnd');
3131
});
3232
socket.write(content);
33-
}).listen(common.PORT, function() {
33+
}).listen(common.PORT, common.localhostIPv4, function() {
3434
console.log('listening');
3535
});
3636
}
3737

3838
function client() {
3939
var net = require('net');
4040
var client = net.connect({
41-
host: 'localhost',
41+
host: common.localhostIPv4,
4242
port: common.PORT
4343
}, function() {
4444
client.destroy();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.