Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7d4941f

Browse filesBrowse files
vsemozhetbytMylesBorins
authored andcommitted
test: fix args in parallel/test-fs-null-bytes.js
The functions `fs.appendFile()` and `fs.writeFile()` were being called without the required `data` argument. Refs: #11595 Backport-PR-URL: #12477 PR-URL: #11601 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
1 parent 858bbaa commit 7d4941f
Copy full SHA for 7d4941f

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-fs-null-bytes.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-null-bytes.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function check(async, sync) {
2222

2323
check(fs.access, fs.accessSync, 'foo\u0000bar');
2424
check(fs.access, fs.accessSync, 'foo\u0000bar', fs.F_OK);
25-
check(fs.appendFile, fs.appendFileSync, 'foo\u0000bar');
25+
check(fs.appendFile, fs.appendFileSync, 'foo\u0000bar', 'abc');
2626
check(fs.chmod, fs.chmodSync, 'foo\u0000bar', '0644');
2727
check(fs.chown, fs.chownSync, 'foo\u0000bar', 12, 34);
2828
check(fs.link, fs.linkSync, 'foo\u0000bar', 'foobar');
@@ -46,7 +46,7 @@ check(null, fs.unwatchFile, 'foo\u0000bar', common.fail);
4646
check(fs.utimes, fs.utimesSync, 'foo\u0000bar', 0, 0);
4747
check(null, fs.watch, 'foo\u0000bar', common.fail);
4848
check(null, fs.watchFile, 'foo\u0000bar', common.fail);
49-
check(fs.writeFile, fs.writeFileSync, 'foo\u0000bar');
49+
check(fs.writeFile, fs.writeFileSync, 'foo\u0000bar', 'abc');
5050

5151
// an 'error' for exists means that it doesn't exist.
5252
// one of many reasons why this file is the absolute worst.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.