Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7d0ffee

Browse filesBrowse files
bnoordhuisBridgeAR
bnoordhuis
authored and
BridgeAR
committed
build: unbreak --with-intl=system-icu build
Include directories are configured by the tools/icu/icu-*.gyp files. The v8.gyp file doesn't need to add them and in fact the way it did that breaks when building against an external copy of ICU. Fixes: #28052 PR-URL: #28118 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 0931f7e commit 7d0ffee
Copy full SHA for 7d0ffee

File tree

Expand file treeCollapse file tree

1 file changed

+0
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-7
lines changed
Open diff view settings
Collapse file

‎tools/v8_gypfiles/v8.gyp‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/v8.gyp
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -393,13 +393,6 @@
393393
'<(icu_gyp_path):icui18n',
394394
'<(icu_gyp_path):icuuc',
395395
],
396-
'direct_dependent_settings': {
397-
'include_dirs': [
398-
'<(icu_path)/source/common',
399-
'<(icu_path)/source/i18n',
400-
'<(icu_path)/source/tools/toolutil',
401-
],
402-
},
403396
}],
404397
],
405398
}, # v8_maybe_icu

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.