Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7cde699

Browse filesBrowse files
mmarchiniBethGriggs
authored andcommitted
doc: harden policy around objections
Harden policy around objections to avoid misunderstanding and to encourage collaboration between pull request authors and objectors. Fixes: #34564 PR-URL: #34639 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 9a7c87d commit 7cde699
Copy full SHA for 7cde699

File tree

Expand file treeCollapse file tree

1 file changed

+16
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-8
lines changed
Open diff view settings
Collapse file

‎doc/guides/collaborator-guide.md‎

Copy file name to clipboardExpand all lines: doc/guides/collaborator-guide.md
+16-8Lines changed: 16 additions & 8 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,22 @@ needed [approvals](#code-reviews), [CI](#testing-and-ci), and
120120
except the [wait time](#waiting-for-approvals), please add the
121121
[`author ready`](#author-ready-pull-requests) label.
122122

123-
Where there is disagreement among Collaborators, consensus should be sought if
124-
possible. If reaching consensus is not possible, a Collaborator may escalate the
125-
issue to the TSC.
126-
127-
Collaborators should not block a pull request without providing a reason.
128-
Another Collaborator may ask an objecting Collaborator to explain their
129-
objection. If the objector is unresponsive, another Collaborator may dismiss the
130-
objection.
123+
If a collaborator believes a pull request should not land as is, **the "Request
124+
Changes" GitHub feature must be used to make the objection explicit**. An
125+
implicit objection not using the "Request Changes" feature is not a
126+
blocker for a pull request. Pull requests with an explicit objection should
127+
not land until all objections are satisfied. Collaborators should not block a
128+
pull request without providing a reason. **Providing a set of actionable steps
129+
alongside the objection is recommended, and the objector must be willing to
130+
work with the pull request author to reach a consensus about the direction of
131+
the pull request**. If reaching consensus is not possible, a Collaborator may
132+
escalate the issue to the TSC.
133+
134+
If the objection is not clear to others, another Collaborator may ask an
135+
objecting Collaborator to explain their objection or to provide actionable
136+
steps to resolve the objection. **If the objector is unresponsive for seven
137+
days after a collaborator asks for clarification, another Collaborator may
138+
dismiss the objection**.
131139

132140
[Breaking changes](#breaking-changes) must receive
133141
[TSC review](#involving-the-tsc). If two TSC members approve the pull request

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.