Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7c9fa11

Browse filesBrowse files
cjihrigtargos
authored andcommitted
test: fix race condition in test-child-process-bad-stdio
test-child-process-bad-stdio.js contains a race condition between a timeout in the test process and a timeout in the spawned child process. This commit addresses the race condition by having the child process wait indefinitely to be killed. PR-URL: #56845 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
1 parent 3999786 commit 7c9fa11
Copy full SHA for 7c9fa11

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-child-process-bad-stdio.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-bad-stdio.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const common = require('../common');
44

55
if (process.argv[2] === 'child') {
6-
setTimeout(() => {}, common.platformTimeout(100));
6+
setTimeout(() => {}, common.platformTimeout(1000));
77
return;
88
}
99

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.