Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7c427bd

Browse filesBrowse files
benglcjihrig
bengl
authored and
cjihrig
committed
doc: clarify "Reviewed-By" iff "LGTM"
As per conversation with @Trott, make it clear that Reviewed-By lines should only be added for collaborators who've actually put a LGTM on the PR. PR-URL: #7183 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: JacksonTian - Jackson Tian <shvyo1987@gmail.com>
1 parent b5beae2 commit 7c427bd
Copy full SHA for 7c427bd

File tree

Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-0
lines changed
Open diff view settings
Collapse file

‎doc/onboarding.md‎

Copy file name to clipboardExpand all lines: doc/onboarding.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ Landing a PR
169169
* `Reviewed-By: human <email>`
170170
* Easiest to use `git log` then do a search
171171
* (`/Name` + `enter` (+ `n` as much as you need to) in vim)
172+
* Only include collaborators who have commented "LGTM"
172173
* `PR-URL: <full-pr-url>`
173174
* `git push upstream master`
174175
* close the original PR with "Landed in `<commit hash>`".

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.