Commit 7c06eab
authored
Revert "http: do not leak error listeners"
This reverts commit 736a7d8.
The patch attempted to fix an issue, signaled by a warning, caused by
an invalid API usage. However it introduced a behavior change that is
breaking userland modules.
It is a user error, so restore the original behavior and have the user
investigate and fix the issue in their code.
Refs: #43587 (comment)
Refs: #43587 (comment)
PR-URL: #44921
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>1 parent 3fdf6cf commit 7c06eabCopy full SHA for 7c06eab
File tree
Expand file treeCollapse file tree
2 files changed
+1
-48
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+1
-48
lines changedOpen diff view settings
Collapse file
+1-4Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
809 | 809 | |
810 | 810 | |
811 | 811 | |
812 | | - |
813 | | - |
814 | | - |
815 | | - |
| 812 | + |
816 | 813 | |
817 | 814 | |
818 | 815 | |
|
Collapse file
test/parallel/test-http-socket-listeners.js
Copy file name to clipboardExpand all lines: test/parallel/test-http-socket-listeners.js-44Lines changed: 0 additions & 44 deletions
This file was deleted.
0 commit comments