Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7ac760b

Browse filesBrowse files
bnoordhuisMylesBorins
bnoordhuis
authored and
MylesBorins
committed
src: fix SetClientCertEngine() nullptr dereference
Introduced in commit 6ee985f ("tls: implement clientCertEngine option") which was merged November 11. PR-URL: #16965 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f6ec5fa commit 7ac760b
Copy full SHA for 7ac760b

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1348,7 +1348,8 @@ void SecureContext::SetClientCertEngine(
13481348
CHECK_EQ(args.Length(), 1);
13491349
CHECK(args[0]->IsString());
13501350

1351-
SecureContext* sc = Unwrap<SecureContext>(args.This());
1351+
SecureContext* sc;
1352+
ASSIGN_OR_RETURN_UNWRAP(&sc, args.Holder());
13521353

13531354
MarkPopErrorOnReturn mark_pop_error_on_return;
13541355

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.