Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7ab1f46

Browse filesBrowse files
avivkelleraduh95
authored andcommitted
build: stop pre-compiling lint-md
PR-URL: #55266 Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent b1ca7ab commit 7ab1f46
Copy full SHA for 7ab1f46

File tree

Expand file treeCollapse file tree

11 files changed

+229
-24600
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

11 files changed

+229
-24600
lines changed
Open diff view settings
Collapse file

‎.github/dependabot.yml‎

Copy file name to clipboardExpand all lines: .github/dependabot.yml
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,16 @@ updates:
2222
applies-to: version-updates
2323
patterns:
2424
- '*'
25+
26+
- package-ecosystem: npm
27+
directory: /tools/lint-md
28+
schedule:
29+
interval: monthly
30+
commit-message:
31+
prefix: tools
32+
open-pull-requests-limit: 10
33+
groups:
34+
lint-md:
35+
applies-to: version-updates
36+
patterns:
37+
- '*'
Collapse file

‎.github/workflows/tools.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/tools.yml
-19Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ on:
2828
- histogram
2929
- icu
3030
# - libuv
31-
- lint-md-dependencies
3231
- llhttp
3332
- minimatch
3433
- nbytes
@@ -187,24 +186,6 @@ jobs:
187186
# cat temp-output
188187
# tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
189188
# rm temp-output
190-
- id: lint-md-dependencies
191-
subsystem: tools
192-
label: tools
193-
run: |
194-
cd tools/lint-md
195-
npm ci
196-
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
197-
if [ "$NEW_VERSION" != "" ]; then
198-
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
199-
rm -rf package-lock.json node_modules
200-
# Include $NEW_VERSION to explicitly update the package.json
201-
# entry for the dependency and also so that semver-major updates
202-
# are not skipped.
203-
npm install --ignore-scripts $NEW_VERSION
204-
npm install --ignore-scripts
205-
cd ../..
206-
make lint-md-rollup
207-
fi
208189
- id: llhttp
209190
subsystem: deps
210191
label: dependencies
Collapse file

‎.gitignore‎

Copy file name to clipboardExpand all lines: .gitignore
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ tools/*/*.i.tmp
114114
/tools/doc/node_modules
115115
/tools/clang-format/node_modules
116116
/tools/eslint/node_modules
117+
/tools/lint-md/node_modules
117118

118119
# === Rules for test artifacts ===
119120
/*.tap
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+8-17Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,21 +1335,6 @@ bench-addons-clean:
13351335
$(RM) -r benchmark/napi/*/build
13361336
$(RM) benchmark/napi/.buildstamp
13371337

1338-
.PHONY: lint-md-rollup
1339-
lint-md-rollup:
1340-
$(RM) tools/.*mdlintstamp
1341-
cd tools/lint-md && npm ci && npm run build
1342-
1343-
.PHONY: lint-md-clean
1344-
.NOTPARALLEL: lint-md-clean
1345-
lint-md-clean:
1346-
$(RM) -r tools/lint-md/node_modules
1347-
$(RM) tools/.*mdlintstamp
1348-
1349-
.PHONY: lint-md-build
1350-
lint-md-build:
1351-
$(warning Deprecated no-op target 'lint-md-build')
1352-
13531338
ifeq ("$(wildcard tools/.mdlintstamp)","")
13541339
LINT_MD_NEWER =
13551340
else
@@ -1361,8 +1346,13 @@ LINT_MD_FILES = $(shell $(FIND) $(LINT_MD_TARGETS) -type f \
13611346
! -path '*node_modules*' ! -path 'test/fixtures/*' -name '*.md' \
13621347
$(LINT_MD_NEWER))
13631348
run-lint-md = tools/lint-md/lint-md.mjs $(LINT_MD_FILES)
1349+
1350+
# Check for a specific file, as (empty) directories are persisted in git.
1351+
tools/lint-md/node_modules/remark-parse/package.json:
1352+
-cd tools/lint-md && $(call available-node,$(run-npm-ci))
1353+
13641354
# Lint all changed markdown files maintained by us
1365-
tools/.mdlintstamp: $(LINT_MD_FILES)
1355+
tools/.mdlintstamp: tools/lint-md/node_modules/remark-parse/package.json $(LINT_MD_FILES)
13661356
$(info Running Markdown linter...)
13671357
@$(call available-node,$(run-lint-md))
13681358
@touch $@
@@ -1372,7 +1362,7 @@ lint-md: lint-js-doc | tools/.mdlintstamp ## Lint the markdown documents maintai
13721362

13731363
run-format-md = tools/lint-md/lint-md.mjs --format $(LINT_MD_FILES)
13741364
.PHONY: format-md
1375-
format-md: ## Format the markdown documents maintained by us in the codebase.
1365+
format-md: tools/lint-md/node_modules/remark-parse/package.json ## Format the markdown documents maintained by us in the codebase.
13761366
@$(call available-node,$(run-format-md))
13771367

13781368

@@ -1601,6 +1591,7 @@ lint-clean: ## Remove linting artifacts.
16011591
$(RM) tools/.*lintstamp
16021592
$(RM) .eslintcache
16031593
$(RM) -r tools/eslint/node_modules
1594+
$(RM) -r tools/lint-md/node_modules
16041595
$(RM) tools/pip/site_packages
16051596

16061597
HAS_DOCKER ?= $(shell command -v docker > /dev/null 2>&1; [ $$? -eq 0 ] && echo 1 || echo 0)
Collapse file

‎eslint.config.mjs‎

Copy file name to clipboardExpand all lines: eslint.config.mjs
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ export default [
5454
'test/message/esm_display_syntax_error.mjs',
5555
'tools/github_reporter/**',
5656
'tools/icu/**',
57-
'tools/lint-md/lint-md.mjs',
5857
],
5958
},
6059
// #endregion
Collapse file

‎tools/lint-md/.gitignore‎

Copy file name to clipboardExpand all lines: tools/lint-md/.gitignore
-1Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.