Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7a8fa2d

Browse filesBrowse files
committed
deps: fix V8 build on Windows with MSVC
PR-URL: #44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 83b0aaa commit 7a8fa2d
Copy full SHA for 7a8fa2d

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.6',
39+
'v8_embedder_string': '-node.7',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/src/wasm/function-body-decoder-impl.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/wasm/function-body-decoder-impl.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2136,7 +2136,7 @@ class WasmDecoder : public Decoder {
21362136
}
21372137

21382138
// TODO(clemensb): This is only used by the interpreter; move there.
2139-
V8_EXPORT_PRIVATE std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
2139+
std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
21402140
WasmOpcode opcode = static_cast<WasmOpcode>(*pc);
21412141
// Handle "simple" opcodes with a fixed signature first.
21422142
const FunctionSig* sig = WasmOpcodes::Signature(opcode);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.