Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7a769eb

Browse filesBrowse files
TrottMylesBorins
Trott
authored and
MylesBorins
committed
doc: add squash guideline to pull-requests doc
Tell the contributor to generally not squash commits during the pull request review process. PR-URL: #20413 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 166df9e commit 7a769eb
Copy full SHA for 7a769eb

File tree

Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎doc/guides/contributing/pull-requests.md‎

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md
+4-3Lines changed: 4 additions & 3 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -599,9 +599,10 @@ whether the failure was caused by the changes in the Pull Request.
599599

600600
### Commit Squashing
601601

602-
When the commits in your Pull Request land, they may be squashed
603-
into one commit per logical change. Metadata will be added to the commit
604-
message (including links to the Pull Request, links to relevant issues,
602+
In most cases, do not squash commits that you add to your Pull Request during
603+
the review process. When the commits in your Pull Request land, they may be
604+
squashed into one commit per logical change. Metadata will be added to the
605+
commit message (including links to the Pull Request, links to relevant issues,
605606
and the names of the reviewers). The commit history of your Pull Request,
606607
however, will stay intact on the Pull Request page.
607608

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.