Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 79fdc6b

Browse filesBrowse files
addaleaxMylesBorins
authored andcommitted
cli: allow --huge-max-old-generation-size in NODE_OPTIONS
PR-URL: #32251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent 3825afe commit 79fdc6b
Copy full SHA for 79fdc6b

File tree

Expand file treeCollapse file tree

3 files changed

+7
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+7
-0
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+1Lines changed: 1 addition & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1196,6 +1196,7 @@ V8 options that are allowed are:
11961196
<!-- node-options-v8 start -->
11971197
* `--abort-on-uncaught-exception`
11981198
* `--disallow-code-generation-from-strings`
1199+
* `--huge-max-old-generation-size`
11991200
* `--interpreted-frames-native-stack`
12001201
* `--jitless`
12011202
* `--max-old-space-size`
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -569,6 +569,11 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
569569
"disallow eval and friends",
570570
V8Option{},
571571
kAllowedInEnvironment);
572+
AddOption("--huge-max-old-generation-size",
573+
"increase default maximum heap size on machines with 16GB memory "
574+
"or more",
575+
V8Option{},
576+
kAllowedInEnvironment);
572577
AddOption("--jitless",
573578
"disable runtime allocation of executable memory",
574579
V8Option{},
Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ if (common.hasCrypto) {
6767
// V8 options
6868
expect('--abort_on-uncaught_exception', 'B\n');
6969
expect('--disallow-code-generation-from-strings', 'B\n');
70+
expect('--huge-max-old-generation-size', 'B\n');
7071
expect('--jitless', 'B\n');
7172
expect('--max-old-space-size=0', 'B\n');
7273
expect('--stack-trace-limit=100',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.