Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 79e3e50

Browse filesBrowse files
watildedanielleadams
authored andcommitted
doc: update example ICU URL
PR-URL: #35373 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 4d29fb5 commit 79e3e50
Copy full SHA for 79e3e50

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎doc/guides/maintaining-icu.md‎

Copy file name to clipboardExpand all lines: doc/guides/maintaining-icu.md
+2-2Lines changed: 2 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ V8 will not compile.
8383

8484
```c
8585
// deps/v8/src/objects/intl-objects.h
86-
#define V8_MINIMUM_ICU_VERSION 64
86+
#define V8_MINIMUM_ICU_VERSION 65
8787
```
8888
8989
V8 in Node.js depends on the ICU version supplied by Node.js.
@@ -104,7 +104,7 @@ should be sufficient).
104104
```bash
105105
./configure \
106106
--with-intl=full-icu \
107-
--with-icu-source=http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz
107+
--with-icu-source=https://github.com/unicode-org/icu/releases/download/release-67-1/icu4c-67_1-src.tgz
108108
make
109109
```
110110

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.