Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 79d4986

Browse filesBrowse files
sarahmeyerMylesBorins
authored andcommitted
doc: update CONTRIBUTING.MD with link to V8 guide
Currently, two of the guides in the `/doc/guides` directory are actually guides for working on the Nodei.js project. Of those, one is linked from this page. This change adds a note to point people to the other. PR-URL: #10070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 42da81e commit 79d4986
Copy full SHA for 79d4986

File tree

Expand file treeCollapse file tree

1 file changed

+9
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+9
-4
lines changed
Open diff view settings
Collapse file

‎CONTRIBUTING.md‎

Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+9-4Lines changed: 9 additions & 4 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -60,17 +60,22 @@ always welcome but API or behavioral changes to modules at stability level 3
6060
Node.js has several bundled dependencies in the *deps/* and the *tools/*
6161
directories that are not part of the project proper. Any changes to files
6262
in those directories or its subdirectories should be sent to their respective
63-
projects. Do not send your patch to us, we cannot accept it.
63+
projects. Do not send a patch to Node.js. We cannot accept such patches.
6464

6565
In case of doubt, open an issue in the
6666
[issue tracker](https://github.com/nodejs/node/issues/) or contact one of the
6767
[project Collaborators](https://github.com/nodejs/node/#current-project-team-members).
6868

6969
Especially do so if you plan to work on something big. Nothing is more
7070
frustrating than seeing your hard work go to waste because your vision
71-
does not align with the project team. Node.js has two IRC channels,
72-
[#Node.js](http://webchat.freenode.net/?channels=node.js) for general help and questions, and
73-
[#Node-dev](http://webchat.freenode.net/?channels=node-dev) for development of node core specifically.
71+
does not align with the project team. (Node.js has two IRC channels:
72+
[#Node.js](http://webchat.freenode.net/?channels=node.js) for general help and
73+
questions, and
74+
[#Node-dev](http://webchat.freenode.net/?channels=node-dev) for development of
75+
Node.js core specifically.
76+
77+
For instructions on updating the version of V8 included in the *deps/*
78+
directory, please refer to [the Maintaining V8 in Node.js guide](https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md).
7479

7580

7681
### Step 2: Branch

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.