Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 79bd39c

Browse filesBrowse files
targosMyles Borins
authored andcommitted
build: add v8 requirement to test-v8* in Makefile
The test targets expect that V8 is built in deps/v8/out Ref: #7477 PR-URL: #7482 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b956635 commit 79bd39c
Copy full SHA for 79bd39c

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,22 +227,22 @@ test-timers:
227227
test-timers-clean:
228228
$(MAKE) --directory=tools clean
229229

230-
test-v8:
230+
test-v8: v8
231231
# note: performs full test unless QUICKCHECK is specified
232232
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
233233
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
234234
--no-presubmit \
235235
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
236236
$(TAP_V8)
237237

238-
test-v8-intl:
238+
test-v8-intl: v8
239239
# note: performs full test unless QUICKCHECK is specified
240240
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
241241
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
242242
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
243243
$(TAP_V8_INTL)
244244

245-
test-v8-benchmarks:
245+
test-v8-benchmarks: v8
246246
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
247247
--download-data $(QUICKCHECK_ARG) --no-presubmit \
248248
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.