Commit 79b1bf5
test: use assert() in N-API async test
The `Execute()` callback is not allowed to call into JS, so
we should use `assert()` instead of potentially throwing JS errors.
PR-URL: #28423
Fixes: nodejs/help#1998
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 14f6cee commit 79b1bf5Copy full SHA for 79b1bf5
File tree
Expand file treeCollapse file tree
1 file changed
+2
-4
lines changedOpen diff view settings
Filter options
- test/node-api/test_async
Expand file treeCollapse file tree
1 file changed
+2
-4
lines changedOpen diff view settings
Collapse file
test/node-api/test_async/test_async.cc
Copy file name to clipboardExpand all lines: test/node-api/test_async/test_async.cc+2-4Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
1 | 2 | |
2 | 3 | |
3 | 4 | |
| ||
29 | 30 | |
30 | 31 | |
31 | 32 | |
32 | | - |
33 | | - |
34 | | - |
35 | | - |
| 33 | + |
36 | 34 | |
37 | 35 | |
38 | 36 | |
|
0 commit comments