Commit 780395f
src: fix use-after-free in inspector agent
uv_close() is an asynchronous operation. Calling it on a data member
inside the destructor is unsound because its memory is about to be
reclaimed but libuv is not done with it yet.
PR-URL: #7907
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 9d45569 commit 780395fCopy full SHA for 780395f
File tree
Expand file treeCollapse file tree
1 file changed
+13
-10
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
1 file changed
+13
-10
lines changedOpen diff view settings
Collapse file
+13-10Lines changed: 13 additions & 10 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
208 | 208 | |
209 | 209 | |
210 | 210 | |
211 | | - |
| 211 | + |
212 | 212 | |
213 | 213 | |
214 | 214 | |
| ||
316 | 316 | |
317 | 317 | |
318 | 318 | |
| 319 | + |
319 | 320 | |
320 | 321 | |
321 | 322 | |
322 | 323 | |
323 | 324 | |
324 | 325 | |
325 | 326 | |
326 | | - |
327 | 327 | |
| 328 | + |
| 329 | + |
328 | 330 | |
329 | 331 | |
330 | 332 | |
331 | | - |
332 | | - |
333 | | - |
| 333 | + |
| 334 | + |
| 335 | + |
| 336 | + |
| 337 | + |
334 | 338 | |
335 | 339 | |
336 | 340 | |
337 | 341 | |
338 | 342 | |
339 | 343 | |
340 | | - |
341 | | - |
342 | 344 | |
343 | | - |
| 345 | + |
| 346 | + |
344 | 347 | |
345 | 348 | |
346 | 349 | |
| ||
516 | 519 | |
517 | 520 | |
518 | 521 | |
519 | | - |
| 522 | + |
520 | 523 | |
521 | 524 | |
522 | 525 | |
| ||
558 | 561 | |
559 | 562 | |
560 | 563 | |
561 | | - |
| 564 | + |
562 | 565 | |
563 | 566 | |
564 | 567 | |
|
0 commit comments