Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 77e5856

Browse filesBrowse files
src: turn embedder api overload into default argument
PR-URL: #43629 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
1 parent 67bf674 commit 77e5856
Copy full SHA for 77e5856

File tree

Expand file treeCollapse file tree

2 files changed

+1
-13
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+1
-13
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -862,13 +862,6 @@ int ProcessGlobalArgs(std::vector<std::string>* args,
862862

863863
static std::atomic_bool init_called{false};
864864

865-
int InitializeNodeWithArgs(std::vector<std::string>* argv,
866-
std::vector<std::string>* exec_argv,
867-
std::vector<std::string>* errors) {
868-
return InitializeNodeWithArgs(argv, exec_argv, errors,
869-
ProcessFlags::kNoFlags);
870-
}
871-
872865
int InitializeNodeWithArgs(std::vector<std::string>* argv,
873866
std::vector<std::string>* exec_argv,
874867
std::vector<std::string>* errors,
Collapse file

‎src/node.h‎

Copy file name to clipboardExpand all lines: src/node.h
+1-6Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,16 +250,11 @@ NODE_EXTERN int Stop(Environment* env);
250250
// from argv, fill exec_argv, and possibly add errors resulting from parsing
251251
// the arguments to `errors`. The return value is a suggested exit code for the
252252
// program; If it is 0, then initializing Node.js succeeded.
253-
NODE_EXTERN int InitializeNodeWithArgs(
254-
std::vector<std::string>* argv,
255-
std::vector<std::string>* exec_argv,
256-
std::vector<std::string>* errors);
257-
// TODO(zcbenz): Turn above overloaded version into below's default argument.
258253
NODE_EXTERN int InitializeNodeWithArgs(
259254
std::vector<std::string>* argv,
260255
std::vector<std::string>* exec_argv,
261256
std::vector<std::string>* errors,
262-
ProcessFlags::Flags flags);
257+
ProcessFlags::Flags flags = ProcessFlags::kNoFlags);
263258

264259
enum OptionEnvvarSettings {
265260
kAllowedInEnvironment,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.