Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 768431c

Browse filesBrowse files
Sebastian PlesciucMylesBorins
authored andcommitted
test: dynamic port in cluster worker disconnect
Remove common.PORT from test-cluster-worker-disconnect-on-error possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12457 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
1 parent b1d26d8 commit 768431c
Copy full SHA for 768431c

File tree

Expand file treeCollapse file tree

1 file changed

+18
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+18
-5
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-cluster-worker-disconnect-on-error.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cluster-worker-disconnect-on-error.js
+18-5Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,32 @@
22
const common = require('../common');
33
const http = require('http');
44
const cluster = require('cluster');
5+
const assert = require('assert');
56

67
cluster.schedulingPolicy = cluster.SCHED_NONE;
78

89
const server = http.createServer();
910
if (cluster.isMaster) {
10-
server.listen(common.PORT);
11-
const worker = cluster.fork();
11+
let worker;
12+
13+
server.listen(0, common.mustCall((error) => {
14+
assert.ifError(error);
15+
assert(worker);
16+
17+
worker.send({port: server.address().port});
18+
}));
19+
20+
worker = cluster.fork();
1221
worker.on('exit', common.mustCall(() => {
1322
server.close();
1423
}));
1524
} else {
16-
server.listen(common.PORT);
17-
server.on('error', common.mustCall((e) => {
18-
cluster.worker.disconnect();
25+
process.on('message', common.mustCall((msg) => {
26+
assert(msg.port);
27+
28+
server.listen(msg.port);
29+
server.on('error', common.mustCall((e) => {
30+
cluster.worker.disconnect();
31+
}));
1932
}));
2033
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.