Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 76781bd

Browse filesBrowse files
cjihrigMylesBorins
cjihrig
authored and
MylesBorins
committed
test: remove common.skipIfReportDisabled()
The report feature won't ever be disabled moving forward, so checking for its existence in the tests is no longer needed. PR-URL: #32242 Fixes: #26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 074c3c1 commit 76781bd
Copy full SHA for 76781bd
Expand file treeCollapse file tree

9 files changed

+1
-15
lines changed
Open diff view settings
Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -553,12 +553,6 @@ function skipIfInspectorDisabled() {
553553
}
554554
}
555555

556-
function skipIfReportDisabled() {
557-
if (!process.config.variables.node_report) {
558-
skip('Diagnostic reporting is disabled');
559-
}
560-
}
561-
562556
function skipIf32Bits() {
563557
if (bits < 64) {
564558
skip('The tested feature is not available in 32bit builds');
@@ -700,7 +694,6 @@ const common = {
700694
skipIf32Bits,
701695
skipIfEslintMissing,
702696
skipIfInspectorDisabled,
703-
skipIfReportDisabled,
704697
skipIfWorker,
705698

706699
get enoughTestCpu() {
Collapse file

‎test/report/test-report-config.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-config.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Flags: --experimental-report --report-on-fatalerror --report-on-signal --report-uncaught-exception
22
'use strict';
33
const common = require('../common');
4-
common.skipIfReportDisabled();
54
const assert = require('assert');
65

76
common.expectWarning('ExperimentalWarning',
Collapse file

‎test/report/test-report-fatal-error.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-fatal-error.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

33
const common = require('../common');
4-
common.skipIfReportDisabled();
54
const assert = require('assert');
65
// Testcase to produce report on fatal error (javascript heap OOM)
76
if (process.argv[2] === 'child') {
Collapse file

‎test/report/test-report-getreport.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-getreport.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Flags: --experimental-report
22
'use strict';
33
const common = require('../common');
4-
common.skipIfReportDisabled();
54
const assert = require('assert');
65
const helper = require('../common/report');
76

Collapse file

‎test/report/test-report-signal.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-signal.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
'use strict';
33
// Test producing a report via signal.
44
const common = require('../common');
5-
common.skipIfReportDisabled();
5+
66
if (common.isWindows)
77
return common.skip('Unsupported on Windows.');
88

Collapse file

‎test/report/test-report-uncaught-exception.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-uncaught-exception.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
'use strict';
33
// Test producing a report on uncaught exception.
44
const common = require('../common');
5-
common.skipIfReportDisabled();
65
const assert = require('assert');
76
const helper = require('../common/report');
87
const tmpdir = require('../common/tmpdir');
Collapse file

‎test/report/test-report-uv-handles.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-uv-handles.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ const common = require('../common');
55
if (common.isIBMi)
66
common.skip('IBMi does not support fs.watch()');
77

8-
common.skipIfReportDisabled();
98
if (process.argv[2] === 'child') {
109
// Exit on loss of parent process
1110
const exit = () => process.exit(2);
Collapse file

‎test/report/test-report-worker.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-worker.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Flags: --experimental-report
22
'use strict';
33
const common = require('../common');
4-
common.skipIfReportDisabled();
54
const assert = require('assert');
65
const { Worker } = require('worker_threads');
76
const { once } = require('events');
Collapse file

‎test/report/test-report-writereport.js‎

Copy file name to clipboardExpand all lines: test/report/test-report-writereport.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
// Test producing a report via API call, using the no-hooks/no-signal interface.
55
const common = require('../common');
6-
common.skipIfReportDisabled();
76
const assert = require('assert');
87
const { spawnSync } = require('child_process');
98
const fs = require('fs');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.