Commit 7606136
test: fix assertions in test-snapshot-dns-lookup*
Due to the unfortunate nature of JavaScript, the extraneous arguments
are silently ignored. In this case, the assertion trivially passes
regardless of the given regular expressions.
Refs: #44633
PR-URL: #46618
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent c07511b commit 7606136Copy full SHA for 7606136
File tree
Expand file treeCollapse file tree
3 files changed
+6
-6
lines changedOpen diff view settings
Filter options
- test
- internet
- parallel
Expand file treeCollapse file tree
3 files changed
+6
-6
lines changedOpen diff view settings
Collapse file
test/internet/test-snapshot-dns-lookup.js
Copy file name to clipboardExpand all lines: test/internet/test-snapshot-dns-lookup.js+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
19 | 19 | |
20 | 20 | |
21 | 21 | |
22 | | - |
23 | | - |
| 22 | + |
| 23 | + |
24 | 24 | |
25 | 25 | |
26 | 26 | |
|
Collapse file
test/parallel/test-snapshot-dns-lookup-localhost-promise.js
Copy file name to clipboardExpand all lines: test/parallel/test-snapshot-dns-lookup-localhost-promise.js+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
19 | 19 | |
20 | 20 | |
21 | 21 | |
22 | | - |
23 | | - |
| 22 | + |
| 23 | + |
24 | 24 | |
25 | 25 | |
26 | 26 | |
|
Collapse file
test/parallel/test-snapshot-dns-lookup-localhost.js
Copy file name to clipboardExpand all lines: test/parallel/test-snapshot-dns-lookup-localhost.js+2-2Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
19 | 19 | |
20 | 20 | |
21 | 21 | |
22 | | - |
23 | | - |
| 22 | + |
| 23 | + |
24 | 24 | |
25 | 25 | |
26 | 26 | |
|
0 commit comments